opacus icon indicating copy to clipboard operation
opacus copied to clipboard

mismatch between the documentation and the behaviour of `make_private_with_epsilon`

Open omarfoq opened this issue 2 years ago • 0 comments

PrivacyEngine.make_private_with_epsilon does not behave as explained by the documentation. In particular, poisson_sampling can not passed as an argument to this method. I think that the error is due to calling get_noise_multiplier (in accountants/utils.py) with **kwargs, but RDPAccountant.get_epsilon (in rdp.py) and GaussianAccountant.get_epsilon (in gdp.py) only accepts a fixed number of arguments. Also, I think that the signature of GaussianAccountant.get_epsilon should be get_epsilon(self, delta: float, poisson_sampling: bool = True) -> float

omarfoq avatar Aug 10 '22 06:08 omarfoq