multipy icon indicating copy to clipboard operation
multipy copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

update pybind to 2.10.2

Open PaliC opened this issue 2 years ago • 5 comments

Updated to unblock https://github.com/pytorch/pytorch/pull/91248#issuecomment-1402327940 and the refcount debug utils will be useful :)

PaliC avatar Jan 24 '23 18:01 PaliC

@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jan 24 '23 18:01 facebook-github-bot

I opened a new PR to try v2.10.3 which is almost identical but turns the refcount debug utils off by default (until pybind111 2.11) and has some misc fixes.

Skylion007 avatar Jan 25 '23 15:01 Skylion007

Hmm so it looks like there is some GIL issues. One common failure case we saw from this is trying store a python object as a global static variable (as the ctor would be called before the interpreter is initialized).

Skylion007 avatar Jan 25 '23 15:01 Skylion007

Gotcha, will enable testing for #305

I'll take a look to see if there's any global static py::objects

PaliC avatar Jan 26 '23 16:01 PaliC

Hmm, are there atexit hooks in this codebase? I think there is an open issue with those that needs to be fixed.

Skylion007 avatar Feb 01 '23 21:02 Skylion007