kineto icon indicating copy to clipboard operation
kineto copied to clipboard

How to add customized metadata with on demand profiling ?

Open staugust opened this issue 11 months ago • 2 comments

When profiling with torch.profiler.profile , generated json file has a section called distributedInfo shown as below

{
  "distributedInfo": {"backend": "nccl", "rank": 0, "world_size": 2}
}

But there's no such section in generated file when on-demand profiling is triggered. As a result, Holistic Trace Analysis cannot be used to analysis those files. Is this by design or there's something to do to make those file generated by kineto have distributedInfo as well? Hoping some one can help. Thanks.

staugust avatar Mar 04 '24 09:03 staugust

This is a bug, if you would like, please submit a fix for this issue. cc @briancoutinho

aaronenyeshi avatar Apr 23 '24 15:04 aaronenyeshi

This is a bug, if you would like, please submit a fix for this issue. cc @briancoutinho

Thanks for kindly response, I will give it a try in few days.

staugust avatar May 13 '24 10:05 staugust

@staugust do you still plan on working on this?

sraikund16 avatar May 30 '24 23:05 sraikund16

@sraikund16 I'm afraid I don't have enough time to work on this in next one or two weeks. It would be great if you have time to solve it, otherwise, I would work on this later.

staugust avatar Jun 03 '24 09:06 staugust

@staugust I am going to take up this task, thanks

sraikund16 avatar Jun 06 '24 16:06 sraikund16

reopening because needs follow up

sraikund16 avatar Jul 03 '24 04:07 sraikund16

Closing for now as this was added for NCCL traces in https://github.com/facebookresearch/HolisticTraceAnalysis/pull/157

If there is a need for gloo/mpi backends we can reopen and do a follow up

sraikund16 avatar Jul 08 '24 21:07 sraikund16