kineto
kineto copied to clipboard
Don't hardcode /opt/rocm in CMakeLists.txt
Most HPC systems use Environment Modules to load libraries. Therefore, the ROCm libraries are loaded explicitly by version: module load rocm/5.6.0
. On the systems I've used ROCM_PATH is defined as /opt/rocm-5.6.0
. I'd suggest changing these lines to ${ROCM_SOURCE _DIR}/lib
.
https://github.com/pytorch/kineto/blob/490f305345b2c06169b02e98418645f3def47b95/libkineto/CMakeLists.txt#L193-L195
cc @mwootton @jeffdaily
Fixed in #912