ignite icon indicating copy to clipboard operation
ignite copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Edit LRFinder to have more than one parameter

Open JakubDz2208 opened this issue 3 years ago • 4 comments

Fixes #2703

Description: Editing FastaiLRFinder to have more than one parameter

JakubDz2208 avatar Sep 08 '22 16:09 JakubDz2208

Hi @Jacob208M , thanks for this PR. Would you like any help?

sadra-barikbin avatar Sep 17 '22 21:09 sadra-barikbin

@sadra-barikbin Can you review this changes is everything fine please?

JakubDz2208 avatar Sep 19 '22 14:09 JakubDz2208

@sadra-barikbin Can you review this changes is everything fine please?

@Jacob208M I reviewed your changes and put some comments. Are they clear?

sadra-barikbin avatar Sep 20 '22 11:09 sadra-barikbin

@sadra-barikbin Can you review this changes is everything fine please?

@Jacob208M I reviewed your changes and put some comments. Are they clear?

Yes, I'll manage it

JakubDz2208 avatar Sep 20 '22 13:09 JakubDz2208

@sadra-barikbin I just updated my code as you showed me. I haven't added ParamGroupScheduler because I wasn't sure about it.

JakubDz2208 avatar Sep 22 '22 12:09 JakubDz2208

@sadra-barikbin I did changes but now I got my tests failed with info

FAILED test_lr_finder.py::test_multi_group_optimizer[exp] - assert False FAILED test_lr_finder.py::test_multi_group_optimizer[linear] - TypeError: unsupported operand type(s) for -: 'list' and 'list'

Is it a problem with param_scheduler? What should I do with it?

JakubDz2208 avatar Sep 28 '22 15:09 JakubDz2208

@sadra-barikbin I did changes but now I got my tests failed with info

FAILED test_lr_finder.py::test_multi_group_optimizer[exp] - assert False FAILED test_lr_finder.py::test_multi_group_optimizer[linear] - TypeError: unsupported operand type(s) for -: 'list' and 'list'

Is it a problem with param_scheduler? What should I do with it?

Thanks. Could you please push the changes to see where the error arises from?

sadra-barikbin avatar Sep 28 '22 16:09 sadra-barikbin

@sadra-barikbin I did changes but now I got my tests failed with info FAILED test_lr_finder.py::test_multi_group_optimizer[exp] - assert False FAILED test_lr_finder.py::test_multi_group_optimizer[linear] - TypeError: unsupported operand type(s) for -: 'list' and 'list' Is it a problem with param_scheduler? What should I do with it?

Thanks. Could you please push the changes to see where the error arises from?

Done

JakubDz2208 avatar Sep 28 '22 16:09 JakubDz2208

@sadra-barikbin Hi, sorry for my absence, I was busy because my studies have started. I committed your changes but I still see there is an error, now it looks like that: ERROR ignite.engine.engine.Engine:engine.py:1105 Current run is terminating due to exception: 'ParamGroupScheduler' object has no attribute 'get_param' ERROR ignite.engine.engine.Engine:engine.py:1000 Engine run is terminating due to exception: 'ParamGroupScheduler' object has no attribute 'get_param' ====================================================================================== short test summary info ====================================================================================== FAILED test_lr_finder.py::test_multi_group_optimizer[exp] - AttributeError: 'ParamGroupScheduler' object has no attribute 'get_param' FAILED test_lr_finder.py::test_multi_group_optimizer[linear] - AttributeError: 'ParamGroupScheduler' object has no attribute 'get_param'

Can you check it please?

JakubDz2208 avatar Oct 07 '22 13:10 JakubDz2208

@sadra-barikbin Hi, sorry for my absence, I was busy because my studies have started. I committed your changes but I still see there is an error, now it looks like that: ERROR ignite.engine.engine.Engine:engine.py:1105 Current run is terminating due to exception: 'ParamGroupScheduler' object has no attribute 'get_param' ERROR ignite.engine.engine.Engine:engine.py:1000 Engine run is terminating due to exception: 'ParamGroupScheduler' object has no attribute 'get_param' ====================================================================================== short test summary info ====================================================================================== FAILED test_lr_finder.py::test_multi_group_optimizer[exp] - AttributeError: 'ParamGroupScheduler' object has no attribute 'get_param' FAILED test_lr_finder.py::test_multi_group_optimizer[linear] - AttributeError: 'ParamGroupScheduler' object has no attribute 'get_param'

Can you check it please?

get_param is now added to branch master in ignite. You should pull ignite changes to your master. Simply call git fetch && git pull origin master

sadra-barikbin avatar Oct 07 '22 17:10 sadra-barikbin

I pulled new changes and now there is no error from get_param, but simple assertion False. I'm not sure why. Can you look at it?

JakubDz2208 avatar Oct 10 '22 15:10 JakubDz2208

"Check code formatting" step in jobs is failing. Let's fix it first. flake8 which is a code style enforcement tool is raising those errors. You can see them by clicking Details in one of failed jobs bottom.

To install flake8 and other formatting tools being used by Ignite do:

./tests/run_code_style.sh install

You can see errors locally with:

./tests/run_code_style.sh lint

sadra-barikbin avatar Oct 10 '22 20:10 sadra-barikbin

@Jacob208M can you please follow and apply suggestions from this comment: https://github.com/pytorch/ignite/pull/2704#issuecomment-1273793182. so we can advance on this feature. Thanks!

vfdev-5 avatar Oct 14 '22 10:10 vfdev-5

I think is done, flake8 doesn't throw any errors, tests are passing. Could you look at this, please?

JakubDz2208 avatar Oct 14 '22 12:10 JakubDz2208

@Jacob208M can you also run code formatting script:

./tests/run_code_style.sh fmt

vfdev-5 avatar Oct 14 '22 13:10 vfdev-5