ignite icon indicating copy to clipboard operation
ignite copied to clipboard

Update for `timeline_and_event` image

Open ydcjeff opened this issue 3 years ago • 1 comments

📚 Documentation

When I first read about timeline and events in PyTorch-Ignite concepts, I noticed I had to rotate my head around 30 degree to read timeline_and_event image.

Should we update the image so that it will be easier to read?

ydcjeff avatar Oct 20 '21 11:10 ydcjeff

Yes, I think it would helpful :)

vfdev-5 avatar Oct 20 '21 11:10 vfdev-5

@vfdev-5,

Let me know if this looks good or needs some changes.

Replaced the image with png itself. Build the docs locally but links are redirecting to the main website instead of a local page for concepts.

timeline_and_events

pacificdragon avatar Feb 12 '23 08:02 pacificdragon

@pacificdragon thanks for working on that ! Actually, vertical text layout was associated with horizontal time line showing time order of the events. If we want to put text horizontally then we may need to put the time line vertically ?

vfdev-5 avatar Feb 12 '23 19:02 vfdev-5

@vfdev-5 Is it better now?

timeline

pacificdragon avatar Feb 13 '23 15:02 pacificdragon

@pacificdragon thanks, yes, I like it more. @ydcjeff any comments from your side or we can directly proceed with docs update ?

vfdev-5 avatar Feb 13 '23 16:02 vfdev-5

Yea, it looks better now.

ydcjeff avatar Feb 16 '23 15:02 ydcjeff