hub
hub copied to clipboard
Add Robust Video Matting
Adding https://github.com/PeterL1n/RobustVideoMatting
Disabled CI check because the documentation shows how to run our model against videos, but the videos don't exist in the CI environment, so the test will fail.
✔️ Deploy Preview for pytorch-hub-preview ready!
🔨 Explore the source changes: 7dd9984a772edf9b817720cd859302a4b574d3ec
🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/6144be1e21202d00075b3e5e
😎 Browse the preview: https://deploy-preview-223--pytorch-hub-preview.netlify.app
DO NOT MERGE this one yet. We are temporarily making some change in the RVM repo. Will take some time to be available again.
Sounds good, I marked the PR as draft so we don't merge it accidentally. Please ping me when it's ready. BTW, as a follow up to your previous issue: https://github.com/pytorch/hub/issues/224 , the CI should be reliable now :)
This pull request is ready to merge again.
@NicolasHug Can you approve the merge?
@NicolasHug Hi Nicolas. Any updates?
Do we have GPU on the test environment? Otherwise the inference will be too slow.
Yes there's a GPU in the CI. I agree we should try to keep the CI test time within a reasonable limit though.
I don't think I recently have time for making the changes. If we can just merge this I would really appreciate.
@NicolasHug
I don't think I recently have time for making the changes
There's no rush on our side @PeterL1n
Without tests, we have no guarantees that the models we are showcasing on the website run properly, which in the long run can erode the trust our users put into torchhub.
It seems that enabling the test would only involve a simple change as suggested above, so I would prefer waiting until then if you don't mind.