hub icon indicating copy to clipboard operation
hub copied to clipboard

Add Robust Video Matting

Open PeterL1n opened this issue 4 years ago • 11 comments

Adding https://github.com/PeterL1n/RobustVideoMatting

Disabled CI check because the documentation shows how to run our model against videos, but the videos don't exist in the CI environment, so the test will fail.

PeterL1n avatar Aug 30 '21 05:08 PeterL1n

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: 7dd9984a772edf9b817720cd859302a4b574d3ec

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/6144be1e21202d00075b3e5e

😎 Browse the preview: https://deploy-preview-223--pytorch-hub-preview.netlify.app

netlify[bot] avatar Aug 30 '21 05:08 netlify[bot]

DO NOT MERGE this one yet. We are temporarily making some change in the RVM repo. Will take some time to be available again.

PeterL1n avatar Aug 31 '21 16:08 PeterL1n

Sounds good, I marked the PR as draft so we don't merge it accidentally. Please ping me when it's ready. BTW, as a follow up to your previous issue: https://github.com/pytorch/hub/issues/224 , the CI should be reliable now :)

NicolasHug avatar Aug 31 '21 16:08 NicolasHug

This pull request is ready to merge again.

PeterL1n avatar Sep 17 '21 16:09 PeterL1n

@NicolasHug Can you approve the merge?

PeterL1n avatar Sep 19 '21 03:09 PeterL1n

@NicolasHug Hi Nicolas. Any updates?

PeterL1n avatar Sep 24 '21 23:09 PeterL1n

Do we have GPU on the test environment? Otherwise the inference will be too slow.

PeterL1n avatar Sep 27 '21 22:09 PeterL1n

Yes there's a GPU in the CI. I agree we should try to keep the CI test time within a reasonable limit though.

NicolasHug avatar Sep 28 '21 08:09 NicolasHug

I don't think I recently have time for making the changes. If we can just merge this I would really appreciate.

PeterL1n avatar Oct 22 '21 20:10 PeterL1n

@NicolasHug

PeterL1n avatar Nov 08 '21 21:11 PeterL1n

I don't think I recently have time for making the changes

There's no rush on our side @PeterL1n

Without tests, we have no guarantees that the models we are showcasing on the website run properly, which in the long run can erode the trust our users put into torchhub.

It seems that enabling the test would only involve a simple change as suggested above, so I would prefer waiting until then if you don't mind.

NicolasHug avatar Nov 09 '21 16:11 NicolasHug