glow icon indicating copy to clipboard operation
glow copied to clipboard

Do not save size and stride for compute nodes for lowering.

Open dborkovic opened this issue 3 years ago • 6 comments

Summary: Accesses to allocs should be based only on TVs, so JSON used for lowering should not contain stride/shape in compute nodes. Next step is to ensure that lowering is done through TVs only - this will mainly be done by chasing failures in the compile caused by remove JSON data.

Differential Revision: D37335462

dborkovic avatar Jun 23 '22 04:06 dborkovic

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 23 '22 04:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 23 '22 23:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 24 '22 19:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 27 '22 20:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 29 '22 16:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D37335462

facebook-github-bot avatar Jun 30 '22 01:06 facebook-github-bot

Hi @dborkovic!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 27 '22 07:08 facebook-github-bot