functorch icon indicating copy to clipboard operation
functorch copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Reenable tests after https://github.com/pytorch/pytorch/pull/80217 lands

Open zou3519 opened this issue 2 years ago • 9 comments

  • test_vmapjvpall_has_batch_rule_linalg_det_singular_cpu_float32
  • test_vmapvjp_has_batch_rule_linalg_det_cpu_float32

zou3519 avatar Jul 13 '22 15:07 zou3519

fwiw, these two tests should pass once https://github.com/pytorch/pytorch/pull/80217 is merged

lezcano avatar Jul 13 '22 15:07 lezcano

or at least the second one. I'm not sure what's making the first one fail.

lezcano avatar Jul 13 '22 15:07 lezcano

We don't have to support det for now for that test, so please feel free to merge https://github.com/pytorch/pytorch/pull/80217 and we can worry about that test later.

zou3519 avatar Jul 13 '22 17:07 zou3519

@Lezcano will https://github.com/pytorch/pytorch/pull/80217 land soon? If not, since functorch is in pytorch/pytorch now, I want to reenable the above tests to prevent regressions

zou3519 avatar Jul 27 '22 20:07 zou3519

I'm on PTO, I'll look at this when I'm back. Feel free to activate the tests again, and I can skip them or fix them in the pr

lezcano avatar Jul 28 '22 16:07 lezcano

Cool, going to re-enable them. If it's not too difficult we should try to fix them in the PR to avoid regressions

zou3519 avatar Aug 17 '22 19:08 zou3519

It looks like that PR is about to land. Sorry for the very long wait, but I've been a fair amount of time out on PTO

lezcano avatar Aug 20 '22 12:08 lezcano

Np, let's land your PR first and then figure out what is going on with the tests

zou3519 avatar Aug 22 '22 16:08 zou3519

It landed, it was reverted, then it landed again. Let's see if it sticks this time.

lezcano avatar Aug 25 '22 11:08 lezcano