executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Arm backend: Add FuseEqualPlaceholdersPass

Open AdrianLundell opened this issue 8 months ago • 6 comments

This pass optimizes memory usage by finding constant placeholders pointing to identical tensors and fusing them to one single placeholder with multiple users.

Note that Ethos-U Vela is updated to include a bug fix related to shared buffers.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

AdrianLundell avatar Apr 04 '25 06:04 AdrianLundell

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9893

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 17455b42e486187856725ae4bdfc9722f4368206 with merge base a4be2e4e26284306e03c4b716317eb0fdf8eac09 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 04 '25 06:04 pytorch-bot[bot]

qnn fails are unrelated

zingo avatar Apr 04 '25 11:04 zingo

@digantdesai How did it go with this? Did you find any problems we should address/fix?

zingo avatar Apr 11 '25 06:04 zingo

@digantdesai Hi, is it ok to merge this?

AdrianLundell avatar Apr 22 '25 09:04 AdrianLundell

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 25 '25 14:04 facebook-github-bot

Apologies for a delayed response.

Yeah I won't be able to update vela until next week, I pulled this in and if there are no internal failures i.e. the new version of vela is backwards compatible with the one we have internally, we can merge this ASAP.

digantdesai avatar Apr 25 '25 14:04 digantdesai