executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Add view_copy/static_reshape support to XNNPACK delegate

Open GregoryComer opened this issue 10 months ago • 5 comments

Summary

Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension. It also includes conditional support for NHWC, so long as batch and channel are fixed (if batch or channel is modified, the reshape has to be done in the native dim order).

Add support for delegating view_copy in the XNNPACK delegate via the XNN static_reshape operator. This includes support for up to one dynamic dimension.

Test plan

I've added test coverage for view_copy, including dynamic shape support and practitioner constraints, to backends/xnnpack/test/ops/test_view_copy.py.If also added additional tests to cover the new view logic in channels_last_tagged_reshape_pass.

GregoryComer avatar Jan 26 '25 07:01 GregoryComer

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7959

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 7ceda5600a429f1195ec6bc076bc2fbbec67541b with merge base 8af82522fc7f066a9613efe3027471befd250492 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jan 26 '25 07:01 pytorch-bot[bot]

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jan 27 '25 01:01 facebook-github-bot

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Aug 30 '25 00:08 github-actions[bot]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Oct 30 '25 00:10 github-actions[bot]

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D68691788.

meta-codesync[bot] avatar Nov 15 '25 03:11 meta-codesync[bot]

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D68691788.

meta-codesync[bot] avatar Dec 04 '25 07:12 meta-codesync[bot]