executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Arm backend: Make slice-op work without end index

Open oscarandersson8218 opened this issue 1 year ago • 3 comments

If no end index is provided to slice, end index will become huge. Make slice-op handle this by taking min of end and shape[dim] to calculate size attribute.

oscarandersson8218 avatar Oct 01 '24 06:10 oscarandersson8218

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5782

Note: Links to docs will display an error until the docs builds have been completed.

:x: 3 New Failures

As of commit da09354a61d012d55ce79210079166654b22f15a with merge base b6e6d062e30455c96ba8b58c52a6200788721296 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Oct 01 '24 06:10 pytorch-bot[bot]

I guess the job timed out or something? If you rebase it will rerun

digantdesai avatar Oct 03 '24 01:10 digantdesai

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 03 '24 01:10 facebook-github-bot

Still failing Arm CI

digantdesai avatar Oct 08 '24 15:10 digantdesai

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 09 '24 15:10 facebook-github-bot

@digantdesai merged this pull request in pytorch/executorch@befc1a905b7226ffb8d6ef223b47f75721142d89.

facebook-github-bot avatar Oct 09 '24 16:10 facebook-github-bot