executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Type Promote Div

Open mcr229 opened this issue 1 year ago • 2 comments

Summary: In decomposition of Hardsigmoid, we see a divide by 6. When we lift this scalar to a tensor, we then see that the divisor is int64, and the dividend is float32. This allows us to remove the Mixed Dtype and also helps us delegate to XNNPACK

Reviewed By: tarun292, digantdesai

Differential Revision: D60492342

mcr229 avatar Aug 02 '24 01:08 mcr229

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4516

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit f4de0596b1acb1b1d23001c73913a5be810595a0 with merge base ee8359c6d6e12b4fc163c7f63f7068b17b5194f1 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Aug 02 '24 01:08 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D60492342

facebook-github-bot avatar Aug 02 '24 01:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60492342

facebook-github-bot avatar Aug 02 '24 20:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60492342

facebook-github-bot avatar Aug 02 '24 20:08 facebook-github-bot

This pull request has been merged in pytorch/executorch@738842d87abd7d5cba87edc90d9e0a0273ababb6.

facebook-github-bot avatar Aug 02 '24 21:08 facebook-github-bot