executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Clean up llava deps and consolidate all HF deps

Open guangy10 opened this issue 1 year ago • 3 comments

python3 -m examples.portable.scripts.export --model_name="llava" works fine on my mac M1. No strict mode is needed. And can directly working on the most recent transformers lib.

It seems like the old restriction about numpy and transformers are not longer true. If CI gives green light we can cleanup the stale setup for llava and use the root setup (executorch/install_requirements.sh) as the source of truth

guangy10 avatar Jul 19 '24 22:07 guangy10

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4320

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure, 1 Cancelled Job

As of commit a89f1cf2927f5235672dc26fe2acfb78824c9061 with merge base 39aeff99dcb4d320fed090101cf5f95c0be1bcba (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 19 '24 22:07 pytorch-bot[bot]

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 24 '24 19:07 facebook-github-bot

It works now on my Linux devserver, but not in the CI due to OOM on the runner.

guangy10 avatar Jul 24 '24 20:07 guangy10

@larryliu0820 could you help review this PR? I'd like to consolidate to one 🤗 transformers versions for ET. That will make future model enablement and benchmarking much easier

guangy10 avatar Aug 15 '24 18:08 guangy10

@larryliu0820 could you help review this PR? I'd like to consolidate to one 🤗 transformers versions for ET. That will make future model enablement and benchmarking much easier

Can you please rebase? I just cleaned up the dependencies for llava.

larryliu0820 avatar Aug 15 '24 18:08 larryliu0820

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 15 '24 22:08 facebook-github-bot