executorch
executorch copied to clipboard
pytorch
Improve cmake testing setup
- Add build/Test.cmake and provide helper function for users to add tests targets Example:
et_cxx_test(my_test SOURCES my_test.cpp EXTRA_LIBS portable_kernels)
User need to invoke et_cxx_test and add their srcs/deps. Note: gtest, gmock, executorch are added to deps by default.
- Update existign CMakeLists.txt and template test/utils/OSSTest.cmake.in for that
- In test/run_oss_cpp_tests.sh, probe tests so user don't need to add them manually We will utilize add_test from cmake later
Test Plan: sh test/run_oss_cpp_tests.sh
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3666
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:white_check_mark: You can merge normally! (1 Unrelated Failure)
As of commit 229a90fb3221f5209fd10ef95038a9dd213d6872 with merge base dc36ef73eda0ec50cb9644191b03b70ad688a55e (
FLAKY - The following job failed but was likely due to flakiness present on trunk:
- pull / test-llama-runner-linux (fp32, buck2, portable) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@kirklandsign merged this pull request in pytorch/executorch@788676f3099c78983bf9fcaa19526081d2c2db10.