executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Added support for HiFi build for ISS (simulator) under EXECUTORCH_BUILD_CADENCE cmake-config switch

Open cad-audio opened this issue 9 months ago • 2 comments

…LD_CADENCE cmake-config switch.

cad-audio avatar May 16 '24 00:05 cad-audio

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3629

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 16 '24 00:05 pytorch-bot[bot]

Hi @cad-audio!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar May 16 '24 00:05 facebook-github-bot

@cad-audio thanks for addressing the comments.

tarun292 avatar Jun 27 '24 02:06 tarun292

@mcremon-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 27 '24 02:06 facebook-github-bot

@cad-audio still looking into it, but maybe a rebase would help to see if CI gets happier

mcremon-meta avatar Jun 27 '24 17:06 mcremon-meta

@mcremon-meta merged this pull request in pytorch/executorch@8f12da1a34008c645d294843b13142959c6dab97.

facebook-github-bot avatar Jun 28 '24 22:06 facebook-github-bot