executorch icon indicating copy to clipboard operation
executorch copied to clipboard

use edge_compile_config in verifier

Open Gasoonjia opened this issue 1 year ago • 10 comments

Summary: this diff use edge_compile_config to create edge verifier, to replace the original enable and _check_edge_ops. This update has three advantages:

  1. User friendly. Both enable and _check_edge_ops are from edge_compile_config, in the previous setting user needs to manually extract the two attributes from their compile_config then forward them to verifier. Now user can just forward their config to verifier, without extra work.
  2. Consistency. In ET, we use EdgeCompileConfig to control how we lower compile model graph to edge graph. We should use the same config to test whether or not the graph is as we expected, rather than manually set the test criteria.
  3. Decreaase reduntancy. Directly using EdgeCompileConfig can decrease redundancy, expecially if new attribute has been introduced to EdgeCompileConfig, or old need to be removed. Otherwise we need to take forever to add/remove options to verifier

Differential Revision: D57010390

Gasoonjia avatar May 06 '24 19:05 Gasoonjia

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3521

Note: Links to docs will display an error until the docs builds have been completed.

:x: 4 New Failures

As of commit 9ee82f9e5d4a01c1d84d86f6432c4c522e6b171f with merge base 9ceee37329b29f4e326fefc30f8483fba737f817 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar May 06 '24 19:05 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 19:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 20:05 facebook-github-bot

This looks good. Can you add some unit test for the verifier?

larryliu0820 avatar May 06 '24 20:05 larryliu0820

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 20:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 22:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 22:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 23:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D57010390

facebook-github-bot avatar May 06 '24 23:05 facebook-github-bot

This pull request has been merged in pytorch/executorch@d6591ff007b069326e4d812db8b764eb72ed1b22.

facebook-github-bot avatar May 07 '24 04:05 facebook-github-bot

This seems to cause problem from backend/arm tests :( Or could be a sideeffect of https://github.com/pytorch/executorch/pull/2205 also I have uploaded a possible fix https://github.com/pytorch/executorch/pull/3529

zingo avatar May 07 '24 06:05 zingo