executorch
executorch copied to clipboard
use edge_compile_config in verifier
Summary:
this diff use edge_compile_config to create edge verifier, to replace the original enable and _check_edge_ops. This update has three advantages:
- User friendly. Both
enableand_check_edge_opsare fromedge_compile_config, in the previous setting user needs to manually extract the two attributes from their compile_config then forward them to verifier. Now user can just forward their config to verifier, without extra work. - Consistency. In ET, we use
EdgeCompileConfigto control how we lower compile model graph to edge graph. We should use the same config to test whether or not the graph is as we expected, rather than manually set the test criteria. - Decreaase reduntancy. Directly using
EdgeCompileConfigcan decrease redundancy, expecially if new attribute has been introduced toEdgeCompileConfig, or old need to be removed. Otherwise we need to take forever to add/remove options to verifier
Differential Revision: D57010390
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3521
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:x: 4 New Failures
As of commit 9ee82f9e5d4a01c1d84d86f6432c4c522e6b171f with merge base 9ceee37329b29f4e326fefc30f8483fba737f817 ():
NEW FAILURES - The following jobs have failed:
- Apple / test-demo-ios / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 65 - Apple / upload-frameworks-ios (gh)
Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers - pull / unittest / linux (buck2) / linux-job (gh)
backends/arm/test/models/test_mobilenet_v2_arm.py::TestMobileNetV2::test_mv2_tosa_BI - pull / unittest / macos (buck2) / macos-job (gh)
backends/arm/test/models/test_mobilenet_v2_arm.py::TestMobileNetV2::test_mv2_tosa_BI
This comment was automatically generated by Dr. CI and updates every 15 minutes.
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This looks good. Can you add some unit test for the verifier?
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request was exported from Phabricator. Differential Revision: D57010390
This pull request has been merged in pytorch/executorch@d6591ff007b069326e4d812db8b764eb72ed1b22.
This seems to cause problem from backend/arm tests :( Or could be a sideeffect of https://github.com/pytorch/executorch/pull/2205 also I have uploaded a possible fix https://github.com/pytorch/executorch/pull/3529