executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Simplify FunctionRef

Open swolchok opened this issue 1 year ago • 2 comments

Summary: Our version was so stripped down that it behaved equivalently to a function pointer.

Differential Revision: D56799169

swolchok avatar Apr 30 '24 23:04 swolchok

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3442

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit 40d142406c08fd445d94b38a96970ef00a05a4e6 with merge base 34aadcbb969a2e23c672b89a5fba19bc937eaf83 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 30 '24 23:04 pytorch-bot[bot]

Our version was so stripped down that it behaved equivalently to a function pointer.

LOL thanks :)

Thanks @mergennachin for adding the trunk label - I guess this shouldn't break things since we are not introducing new features and should be c++11 compatible.

digantdesai avatar May 01 '24 19:05 digantdesai

this landed

swolchok avatar May 29 '24 15:05 swolchok