executorch icon indicating copy to clipboard operation
executorch copied to clipboard

use c++11 for size test

Open lucylq opened this issue 1 year ago • 7 comments

lucylq avatar Apr 30 '24 22:04 lucylq

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3441

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 64ee6b4743ed20e605956366b3d0870814a18bc1 with merge base b9488fe9d41fe5190641f323f3f6a5295e86256c (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 30 '24 22:04 pytorch-bot[bot]

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '24 18:05 facebook-github-bot

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '24 18:05 facebook-github-bot

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '24 18:05 facebook-github-bot

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 01 '24 19:05 facebook-github-bot

We should test size_test and transitively also libexecutorch to be compilable with C++11

If it's not possible right, let's start with C++14 and then downgrade after fixing the issues.

Next target is size_test_all_ops

mergennachin avatar May 01 '24 19:05 mergennachin

@pytorchbot drci

(please ignore this, I'm testing Dr.CI)

huydhn avatar May 02 '24 02:05 huydhn

@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 02 '24 22:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56834619

facebook-github-bot avatar May 03 '24 17:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56834619

facebook-github-bot avatar May 03 '24 18:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56834619

facebook-github-bot avatar May 03 '24 18:05 facebook-github-bot

@lucylq merged this pull request in pytorch/executorch@3a2b2e8a3d5325d99edddc08decfbe9eaae55292.

facebook-github-bot avatar May 03 '24 21:05 facebook-github-bot