executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

Use macro to implement binary Tensor elementwise comparison ops

Open swolchok opened this issue 1 year ago • 3 comments

Summary: These ops' code is all duplicated; add a macro so we can change it all at once instead of in 6 places.

Differential Revision: D56744651

swolchok avatar Apr 30 '24 06:04 swolchok

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3421

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit cdc383157aa351a5b8a1b263c74f3aa402b2c085 with merge base b9488fe9d41fe5190641f323f3f6a5295e86256c (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 30 '24 06:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56744651

facebook-github-bot avatar May 02 '24 16:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56744651

facebook-github-bot avatar May 02 '24 17:05 facebook-github-bot

abandoning this one for now due to code size regression, probably because nested ET_SWITCH macros generate a gnarly nested switch

swolchok avatar May 06 '24 18:05 swolchok