executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Enable Arm unit test when running pull jobs

Open zingo opened this issue 9 months ago • 13 comments

Trigger and run backend arm tests as par of github ci

zingo avatar Apr 26 '24 11:04 zingo

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3371

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit feaa5a641ff95d240ce9ae83eb40bce26a91c353 with merge base 69f4a2fd09c079eb5af2fa09912bfce6d6ae9a23 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 26 '24 11:04 pytorch-bot[bot]

There are some different way to do this and maybe we could also limit scope of testing to only arm backend test for this job to make it faster, please feel free to comment suggest on your thoughts. :)

zingo avatar Apr 26 '24 11:04 zingo

Please seek CI approval before scheduling CIFlow labels

pytorch-bot[bot] avatar Apr 26 '24 11:04 pytorch-bot[bot]

@pytorchbot label ciflow/trunk

zingo avatar Apr 27 '24 13:04 zingo

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

pytorch-bot[bot] avatar Apr 27 '24 13:04 pytorch-bot[bot]

@pytorchbot label ciflow/trunk

zingo avatar Apr 29 '24 19:04 zingo

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

pytorch-bot[bot] avatar Apr 29 '24 19:04 pytorch-bot[bot]

Please seek CI approval before scheduling CIFlow labels

pytorch-bot[bot] avatar May 01 '24 08:05 pytorch-bot[bot]

@pytorchbot label ciflow/trunk

robell avatar May 01 '24 08:05 robell

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

pytorch-bot[bot] avatar May 01 '24 08:05 pytorch-bot[bot]

@digantdesai @guangy10 anything more you want me to do in this pull request?

zingo avatar May 06 '24 08:05 zingo

Nothing from my side, we are discussing internally but hopefully should resolve today.

digantdesai avatar May 08 '24 14:05 digantdesai

Anything we can change/update in the patch to improve the chance of a fruitful outcome? 😊

Is the time a problem at all?

zingo avatar May 15 '24 19:05 zingo

@pytorchbot label ciflow/trunk

zingo avatar May 21 '24 09:05 zingo

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 21 '24 14:05 facebook-github-bot

Trying to merge now.

digantdesai avatar May 22 '24 03:05 digantdesai

@digantdesai merged this pull request in pytorch/executorch@610eb4fea394a2e76b33fc34d6fab87a48251d8a.

facebook-github-bot avatar May 24 '24 20:05 facebook-github-bot