executorch
executorch copied to clipboard
Audit and update the pip package metadata
Fill out the recommended project
keys, most of which will affect the web page that PyPI will render for the executorch
package.
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#about-your-project for the latest guidance.
Use https://github.com/pytorch/pytorch/blob/a21327e0b03cc18850a0608be2d9c5bd38fd4646/setup.py#L1394 as a guide for the actual values.
Add a README-wheel.md file that will be included in the wheel, and will become the main page contents on PyPI.
Test Plan:
- Installed the package with
./install_requirements.sh
- Looked at the files under ~/miniconda3/envs/executorch/lib/python3.10/site-packages/executorch-0.2.0a0+1a499e0.dist-info. METADATA and LICENSE both contain the new metadata.
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3265
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:x: 1 New Failure
As of commit 2a894162970da4dddb1db1c360d42a391a052fc6 with merge base d3326a2073dee7baf78044fb3afd0772edbc616a ():
NEW FAILURE - The following job has failed:
-
Lint / lintrunner / linux-job (gh)
>>> Lint for sdk/inspector/tests/inspector_test.py:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
There are bunch of CI failures you will need to look into. Please ensure it's addressed before merging
@guangy10 doh, the torch==2.3
is breaking assumptions in the CI environment. This is the requirement that we need when we release, but right now it can't be fulfilled.
I updated this PR to only touch the metadata without adding that dependency line. I'll need to modify the CI scripts to make this work.
I'm not sure why the lint job is failing. Some of the suggestions it's giving look wrong, and I don't see those same suggestions when running locally. I'm re-running the job to see if it was temporary.
EDIT: It was because of the new "python >=3.10" requirement. There's a new with
syntax in 3.10+ that the linter started enforcing. https://github.com/pytorch/executorch/pull/3277 will remove the >=3.10
since we do actually want to try supporting older versions at some point
Trying to reinstate the torch==2.3
dependency in https://github.com/pytorch/executorch/pull/3277
Yeah, this PR doesn't even touch those files.