executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Break flag bc

Open mcr229 opened this issue 1 year ago • 3 comments

Summary: XNNPACK broke Backwards Compatibility by forcing pooling operations to reduce dims, and introducing a flag to allow these operation to keep the dims.

This is backwards breaking because previously XNNPACK would not keep the dims if no flag was given, now a flag must be specified to keep the dims. While initially we proposed the inverse to maintain backwards compatibility, they have encountered breakages and have decided to commit to this breakage. As we are a downstream dependency, and will have to accept this breakages ourselves, it is important that we break early before this is used in any production code.

As a result we break BC Here by accepting XNNPACK's change.

git diff roll_back_commit > rollback.patch
cd fbsource/fbcode/xplat/third-party/XNNPACK/XNNPACK
git apply ../../../../../../rollback.patch

Differential Revision: D56271242

mcr229 avatar Apr 18 '24 16:04 mcr229

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3128

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 0a79fd1cc4e45a1bcdf2443204ebad7139c9a1fb with merge base fff20a738c5bb5c1cb259468b0a8aa6c6be8cd38 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 18 '24 16:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56271242

facebook-github-bot avatar Apr 18 '24 16:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56271242

facebook-github-bot avatar May 08 '24 20:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56271242

facebook-github-bot avatar May 09 '24 17:05 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56271242

facebook-github-bot avatar May 09 '24 17:05 facebook-github-bot

This pull request has been merged in pytorch/executorch@6c5612201249243d7c483bf563529104cbedf2cf.

facebook-github-bot avatar May 09 '24 22:05 facebook-github-bot