executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Remove unused variables in eki/builder/offloading/BlockAllocator.cpp

Open r-barnes opened this issue 1 year ago • 3 comments

Summary: LLVM-15 has a warning -Wunused-but-set-variable which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with [[maybe_unused]], mostly in cases where the variable is used, but, eg, in an assert statement that isn't present in production code.

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: dmm-fb

Differential Revision: D56065747

r-barnes avatar Apr 12 '24 19:04 r-barnes

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3017

Note: Links to docs will display an error until the docs builds have been completed.

:x: 5 New Failures

As of commit 2f6d78ece94fa489f2312f784b524df2647786fb with merge base 458d743bc86387fa4a3190f5d716e65584b41402 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 12 '24 19:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56065747

facebook-github-bot avatar Apr 12 '24 19:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56065747

facebook-github-bot avatar Apr 16 '24 18:04 facebook-github-bot