executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Add executorch_no_prim_ops target

Open pytorchbot opened this issue 10 months ago • 1 comments

Summary: Currently libexecutorch.a always contain prim ops. This becomes a problem when a binary contains 2 "versions" of libexecutorch.a, causing a double registration of the prim ops.

For example, libA.so depends on libexecutorch.a and a binary B depends on both libA.so and libexecutorch.a. Since both libexecutorch.a and libA.so contains prim ops, they will be registered twice.

In this PR I created another library executorch_no_prim_ops for libA.so to depend on.

Differential Revision: D55907752

pytorchbot avatar Apr 10 '24 18:04 pytorchbot

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2970

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure

As of commit 0cf81c08dd14e41d2b9259032386aac643cf3bf7 with merge base d3326a2073dee7baf78044fb3afd0772edbc616a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 10 '24 18:04 pytorch-bot[bot]