pytorch
Remove no-op clones (WIP)
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15838
- :page_facing_up: Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
:x: 2 New Failures, 1 Unrelated Failure
As of commit a745b0c88858fee0e34b0ad92f10ceed47071617 with merge base a09a4b74feb4680c840f37c458fc291e36ce78bd (
NEW FAILURES - The following jobs have failed:
- pull / unittest / macos / macos-job (gh)
export/tests/test_target_recipes.py::TestTargetRecipes::test_mv3_model - pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)
RuntimeError: Command docker exec -t ef0d3a338987f6f2e80623924367bc678b6f384b47f9a66e51011225f6f9d1aa /exec failed with exit code 1
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
- pull / android / run-emulator (gh) (trunk failure)
Timeout waiting for emulator to boot.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
![pytorch-bot[bot] avatar](https://avatars.githubusercontent.com/in/40112?v=4 "Published by a pub.dev verified publisher"){kind=small}
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86588171.
![meta-codesync[bot] avatar](https://avatars.githubusercontent.com/in/1373969?v=4 "Published by a pub.dev verified publisher"){kind=small}
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D86588171.
@MartinPavella @StrycekSimon I'm looking at optimizing out clones more aggressively from the graph during to_edge. I see that the NXP backend has some test coverage looking at clones in the context of the dropout op. Do you have any concerns with removal of clones from the graph? If not, I'm happy to take a pass at updating the tests accordingly.
@MartinPavella @StrycekSimon I'm looking at optimizing out clones more aggressively from the graph during to_edge. I see that the NXP backend has some test coverage looking at clones in the context of the dropout op. Do you have any concerns with removal of clones from the graph? If not, I'm happy to take a pass at updating the tests accordingly.
Hi @GregoryComer , we have no issues with removing clones which leave the dim order unchanged. Feel free to skip our tests for now. We will update them accordingly later if need be.
