executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Introduce PTEFile class

Open lucylq opened this issue 2 months ago • 4 comments

Stack from ghstack (oldest at bottom):

  • #15801
  • -> #15800

PTEFile class holds the components of a PTE file: the program, mutable constants and named data.

Currently, the program definition does not contain mutable constants and named data; they are always stored in segments and not inline. This means when we deserialize, they are lost, because we only deserialize into the program concept.

Now, segment data is included in the PTEFile class.

Differential Revision: D86814175

lucylq avatar Nov 13 '25 02:11 lucylq

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15800

Note: Links to docs will display an error until the docs builds have been completed.

:x: 6 New Failures, 2 Unrelated Failures

As of commit 6c8e9e4eb6235fb7fe33ea4af1b59ea34a5c3f01 with merge base b1e3e28bb611e06d484138be27221faffd89f565 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 13 '25 02:11 pytorch-bot[bot]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar Nov 13 '25 02:11 github-actions[bot]

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

lucylq avatar Nov 14 '25 22:11 lucylq

It might be nice it bundleIO BPTE files could be mixed into this in some way and handled similarly.

@zingo thanks for the suggestion - could you comment a bit more on what you're looking for?

Im thinking the it might be god to have if you made tools parsing the different files. As Im not writing those kind of tools right now Im not sure its fully applicable but I feel the bpte are sometimes forgotten or need special handling.

zingo avatar Nov 14 '25 22:11 zingo