executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Refactor cadence.convolution

Open mcremon-meta opened this issue 1 month ago • 3 comments

Summary: We will then replace them with the native aten versions.

  • Replace cadence.convolution with cadence.conv1d and cadence.conv2d. Add cadence.conv3d.
  • Removes the channel_last arg

Differential Revision: D86473542

mcremon-meta avatar Nov 11 '25 20:11 mcremon-meta

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15762

Note: Links to docs will display an error until the docs builds have been completed.

:x: 6 New Failures, 2 Unrelated Failures

As of commit b5df93465830edba2446fd49b0217c90c63d91c1 with merge base 0c0cee5fd5adfff71fdf896181c51ba984427f48 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 11 '25 20:11 pytorch-bot[bot]

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86473542.

meta-codesync[bot] avatar Nov 11 '25 20:11 meta-codesync[bot]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar Nov 11 '25 20:11 github-actions[bot]