executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Update ReplaceSqueezeAndUnsqueezeWithViewPass to use new pass interface

Open DrJessop opened this issue 2 weeks ago • 3 comments

Summary: As titled, now it is more efficient and correctly updates the modified bit. Updated tests, too

Differential Revision: D86785126

DrJessop avatar Nov 11 '25 18:11 DrJessop

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86785126.

meta-codesync[bot] avatar Nov 11 '25 18:11 meta-codesync[bot]

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15757

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 1 New Failure, 2 Unrelated Failures

As of commit 913f14a18ed86a3af556aa88d5a5cf49b59ac881 with merge base ca4e363cb04dec5aa39128220552739c3ba7a4df (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 11 '25 18:11 pytorch-bot[bot]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar Nov 11 '25 18:11 github-actions[bot]