executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Update ReplaceLogicalNotBooleanWhereWithWherePass to use new pass interface

Open DrJessop opened this issue 3 weeks ago • 3 comments

Summary: As titled, more efficient now and properly updates the modified bit. Also, this pass was missing tests, so added some for a variety of different cases.

Differential Revision: D86782910

DrJessop avatar Nov 11 '25 18:11 DrJessop

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15755

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 9c420a5610731091bbec9ad6822d92e957b5784f with merge base cf0e9aa764847ff6bf1424ec081a85aa9857e62e (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 11 '25 18:11 pytorch-bot[bot]

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86782910.

meta-codesync[bot] avatar Nov 11 '25 18:11 meta-codesync[bot]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar Nov 11 '25 18:11 github-actions[bot]