executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Remove noautodeps from files inc executorch/sdk/bundled_program/schema/test/TARGETS

Open r-barnes opened this issue 2 years ago • 3 comments

Summary: autodeps automatically adds and removes dependencies from targets. Removing dependencies reduces build times, build sizes, and error surfaces. Adding dependencies gives your code the things it needs to work.

This diff removes noautodeps from one or more TARGETS files, opting them into autodeps.

This changes should be low risk because:

  • We have verified that autodeps runs correctly on the modified files
  • The TARGETS files in this diff contain only additions and no removals of dependencies. Additions rarely break code.
  • We have verified that the additions do not create circular dependencies, which are the most common problem when dependencies are added.
  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: meyering

Differential Revision: D51492409

r-barnes avatar Nov 28 '23 19:11 r-barnes

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1302

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit a81a185f0e788e1b7aeaaeff6affce065e5045d4 with merge base 554cd2792cf684818b9f33106eb1a6d19bb1f85b (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 28 '23 19:11 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D51492409

facebook-github-bot avatar Nov 28 '23 19:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D51492409

facebook-github-bot avatar Apr 10 '24 19:04 facebook-github-bot