executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Run test_models.sh with strict=False flag

Open mergennachin opened this issue 5 months ago • 6 comments

This is the recommended anyway, so let's gradually start migrating to strict=False

mergennachin avatar Jul 10 '25 21:07 mergennachin

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12368

Note: Links to docs will display an error until the docs builds have been completed.

:x: 10 New Failures, 2 Unrelated Failures

As of commit c16b6458d4f75616e6c37489240588bef90e296a with merge base a1e3d48feefac850a79f4afc34eb3879cde513a3 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jul 10 '25 21:07 pytorch-bot[bot]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar Jul 10 '25 21:07 github-actions[bot]

@digantdesai yea we should probably check that model size isn't bloated. We don't have any CI here that checks for this so right now we would have to do so manually.

mcr229 avatar Jul 11 '25 17:07 mcr229

@digantdesai yea we should probably check that model size isn't bloated. We don't have any CI here that checks for this so right now we would have to do so manually.

Can we add a CI to make sure it doesn't double or something, just a guard against regressing.

digantdesai avatar Jul 14 '25 09:07 digantdesai

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Sep 13 '25 00:09 github-actions[bot]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Nov 12 '25 00:11 github-actions[bot]