executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Added tensor's dim order ambiguity check

Open patelvndn opened this issue 9 months ago • 5 comments

Summary

Added the ambiguity checks in this pull request to exir/verifier.py

Fixes #9942

patelvndn avatar Apr 17 '25 18:04 patelvndn

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10272

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 55afbd4aba88203d7966f53157a7493411a2a9ff with merge base 4df92903085133c8f9e340127add40690cc8781c (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 17 '25 18:04 pytorch-bot[bot]

Hi @patelvndn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 17 '25 18:04 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Apr 17 '25 20:04 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Apr 17 '25 20:04 facebook-github-bot

@pytorchbot label "module:exir" "topic:not user facing"

patelvndn avatar Apr 30 '25 14:04 patelvndn

Didn't find following labels among repository labels: module:exir,topic:not user facing

pytorch-bot[bot] avatar Apr 30 '25 14:04 pytorch-bot[bot]

@pytorchbot label "topic: not user facing"

patelvndn avatar Apr 30 '25 14:04 patelvndn

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

github-actions[bot] avatar May 22 '25 05:05 github-actions[bot]

Looks good at a high level, left some comments please update the PR, rebased, and running a CI. 🤞

digantdesai avatar May 22 '25 05:05 digantdesai

Bunch of CI failures, please fix those? Thanks.

digantdesai avatar May 22 '25 05:05 digantdesai

Sorry for letting this drop. It has merge conflicts now

JacobSzwejbka avatar Aug 12 '25 23:08 JacobSzwejbka

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Oct 12 '25 00:10 github-actions[bot]