executorch icon indicating copy to clipboard operation
executorch copied to clipboard

[#9971] Gracefully error out in ETDump part 3 for *profiling_delegate

Open zhongmingyuan opened this issue 7 months ago • 9 comments

Summary

Gracefully throw error for

start_profiling_delegate end_profiling_delegate end_profiling_delegate

  1. Changed the method signature to Result<>
  2. Use ET_CHECK_OR_RETURN_ERROR next: check_ready_to_add_event will need to come in later PRs

Test plan

test/run_oss_cpp_tests.sh

Not sure how to trigger CI in draft mode

@Gasoonjia @zhenyan-zhang-meta

zhongmingyuan avatar Apr 14 '25 19:04 zhongmingyuan

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10147

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit a47a195f532b83e4914a2175f78835b686e0fc63 with merge base e84c319665e37e5d730953b2ffbe23c4ae41858b (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 14 '25 19:04 pytorch-bot[bot]

@pytorchbot label "topic: not user facing"

zhongmingyuan avatar Apr 14 '25 19:04 zhongmingyuan

Also please solve the ci issue.

Gasoonjia avatar Apr 14 '25 20:04 Gasoonjia

Not sure how to trigger CI in draft mode

It has to be from us to manually trigger it for you. I've just done it.

Could you also regularly merge the latest changes from main into this branch?

zhenyan-zhang-meta avatar Apr 14 '25 20:04 zhenyan-zhang-meta

@zhenyan-zhang-meta I've merged this onto the latest main branch 15 minutes ago so it should be ok now.

Gasoonjia avatar Apr 14 '25 20:04 Gasoonjia

Also please solve the ci issue.

Most of errors are related to huggingface. I guess they are temporary? Please feel free to suggest how to reproduce it locally here. Thanks

OSError: We couldn't connect to 'https://huggingface.co' to load this file, couldn't find it in the cached files and it looks like google/mobilebert-uncased is not the path to a directory containing a file named config.json.

zhongmingyuan avatar Apr 15 '25 17:04 zhongmingyuan

@Gasoonjia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 15 '25 23:04 facebook-github-bot

Please let me merge it -- there're some internal issue i need to fix

Gasoonjia avatar Apr 16 '25 00:04 Gasoonjia

Please let me merge it -- there're some internal issue i need to fix

@Gasoonjia Thanks!. Do you need me to close this PR and wait for you?

zhongmingyuan avatar Apr 18 '25 04:04 zhongmingyuan

@pytorchbot label "release notes: none"

zhongmingyuan avatar May 16 '25 01:05 zhongmingyuan

@Gasoonjia please help merge this

larryliu0820 avatar May 28 '25 23:05 larryliu0820

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Aug 31 '25 00:08 github-actions[bot]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions[bot] avatar Nov 03 '25 00:11 github-actions[bot]