examples icon indicating copy to clipboard operation
examples copied to clipboard

Upgrade requirements for DDP_RPC examples and Re-enable Makefile test

Open veekaybee opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Currently, we don't run the tests for the distributed module when we run the Makefile sequentially. One of the issues is that distributed/rpc/ddp_rpc/requirements.txt don't work with PyTorch 1.9

See Previous PR work and discussion here.

Describe the solution

We'll need to investigate further to figure out the cause and either update the example or the test accordingly to make it compatible with PyTorch 1.9 and upgrade the pinned version here. distributed/rpc/ddp_rpc/requirements.txt

Describe alternatives solution

Test 1.6 and re-enable the test if we can't get 1.9 to work.

veekaybee avatar Apr 21 '22 02:04 veekaybee

@msaroufim Feel free to assign this to me and make any edits/clarifications to the text.

veekaybee avatar Apr 21 '22 02:04 veekaybee

Nope crystal clear, I'm actually very curious what the changes will end up being

msaroufim avatar Apr 22 '22 20:04 msaroufim