examples icon indicating copy to clipboard operation
examples copied to clipboard

Add distributed usage to ImageNet example's README

Open Quentin-Anthony opened this issue 3 years ago • 3 comments
trafficstars

Following the discussions in #995 and #862, This PR adds a small usage example into the ImageNet README.

One note, however, is that specifying --gpu will trigger the print in https://github.com/pytorch/examples/blob/main/imagenet/main.py#L95-L97, which is confusing to users. Should we either remove or clarify this print?

Quentin-Anthony avatar Apr 30 '22 12:04 Quentin-Anthony

Deploy Preview for pytorch-examples-preview ready!

Name Link
Latest commit 66d9566cbf98be6aa3cfa0d4a0968bb4a0682fd5
Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/626d2944ee570c0008dae0a5
Deploy Preview https://deploy-preview-1001--pytorch-examples-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 30 '22 12:04 netlify[bot]

I think the print for --gpu is useful. To reduce the confusion, we can add some clarification to the print message. Alternative: as DDP is recommended to replace DataParallel, we should probably remove the usage of DataParallel in examples and update the print message accordingly.

hudeven avatar Aug 09 '22 21:08 hudeven

I think the print for --gpu is useful. To reduce the confusion, we can add some clarification to the print message. Alternative: as DDP is recommended to replace DataParallel, we should probably remove the usage of DataParallel in examples and update the print message accordingly.

I'm confused. This PR is for updating the README. What's being printed?

Quentin-Anthony avatar Aug 23 '22 18:08 Quentin-Anthony