data
data copied to clipboard
pytorch
[WIP] pin_memory DataPipe and adapter
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Looks like pin_memory should be a parameter of ReadingService, otherwise 'pin' gets lost when tensors are moved from child processes to the main training loop.
CC @ejguan
Looks like pin_memory should be a parameter of ReadingService, otherwise 'pin' gets lost when tensors are moved from child processes to the main training loop.
CC @ejguan
Do we want to have special DataPipes that can only be iterated on main process (cannot moved to child process)? If so, we might still keep it as an Adapter and use a special DataPipe. FWIW, we might need such feature for DataPipe operations when Tensor is pinned or sent to cuda.
This might depends on the prototype MultiprocessingRS
Makes total sense to me, I will update MPReadingService to respect such DataPipes as part of this PR.
Hi @VitalyFedyunin!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
