cpuinfo icon indicating copy to clipboard operation
cpuinfo copied to clipboard

Refactor CPU ISA to be compiled instead of static

Open BoyeGuillaume opened this issue 6 months ago • 2 comments

This commit introduces a new source file isa.c that implements functions to check for various CPU features across x86, ARM, and RISC-V architectures. This facilitate the definition of FFI for interfacing with other languages such as Rust or Python in automated tooling.

BoyeGuillaume avatar Jun 20 '25 17:06 BoyeGuillaume

Hi @BoyeGuillaume!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 20 '25 17:06 facebook-github-bot

The term FFI seems to mean you want to call cpuinfo from other languages, such as Cobol :-)

I have no strong opinion on the content of this PR, aside from it looks like you did it correctly. Is it possible to include a small unittest to demonstrate?

fbarchard avatar Jun 24 '25 21:06 fbarchard