cpuinfo icon indicating copy to clipboard operation
cpuinfo copied to clipboard

Apply `RESTRICT_STATIC` MSVC workaround to `arm/cache.c` as well

Open MarijnS95 opened this issue 8 months ago • 2 comments

In https://github.com/pytorch/cpuinfo/pull/283 a workaround was introduced to remove the restrict static attributes on MSVC where it is not supported.

This was only defined and used in arm/api.h however and not in arm/cache.c, leading to this file to fail compilation because it is included in ARM_SRCS for the windows_arm64 target in BUILD.bazel.

Fix that by replacing restrict static with RESTRICT_STATIC which will be defined by the arm/api.h header that is already included in arm/cache.c.

MarijnS95 avatar Apr 22 '25 10:04 MarijnS95

Hi @MarijnS95!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 22 '25 10:04 facebook-github-bot

Please sign the CLA to merge the PR

digantdesai avatar May 22 '25 05:05 digantdesai