captum icon indicating copy to clipboard operation
captum copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

change tracin progress test

Open 99warriors opened this issue 2 years ago • 1 comments

Summary: the tests for test_tracin_show_progress were failing we check that the progress reaches 100% X times, but sometimes, the progress reaches 100% more than X times. As aobo-y pointed out, this is because tqdm will sometimes correct its estimate of it/s for the total iteration over progress, and print 100% an additional time, with the updated estimate of it/s. The fix is to check that progress reaches 100% at least X times. We don't check that it reaches 100% either X or X+1 times, because all we can reasonably assume of tqdm is that it may re-estimate it/s >= 0 times. Note that this change is to correct a problem with tqdm, not SimpleProgress.

Differential Revision: D38443861

99warriors avatar Aug 04 '22 23:08 99warriors

This pull request was exported from Phabricator. Differential Revision: D38443861

facebook-github-bot avatar Aug 04 '22 23:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D38443861

facebook-github-bot avatar Aug 17 '22 00:08 facebook-github-bot