builder
builder copied to clipboard
pytorch
fix typos per issue 969
As described in this comment of issue 969, it appears two different typos (MANYLINUX_VERSION vs MANY_LINUX_VERSION and MANY_LINUX_VERSION vs MANY_LINUX_VERSON) hid the fact the environment variable MANYLINUX_VERSION was being ignored and docker.io/pytorch/manylinux-builder is built instead of the expected docker.io/pytorch/manylinux2014-builder when 2014 is set.
MANY_LINUX_VERSION is assumed to be the intended variable name.
Hi @qhaas!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
My employer (Oak Ridge National Laboratory) has reached out to [email protected] concerning the CLA, please check inbox for emails from 'ornl.gov' email addresses.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!