botorch icon indicating copy to clipboard operation
botorch copied to clipboard

[Bug]: Wrong docstring in `MultiTaskGP`

Open AdrianSosic opened this issue 1 month ago • 2 comments

What happened?

Could it be that there is a mistake in the docstring of MultiTaskGP? In the main part, it says:

The standardization is applied in a stratified fashion at the level of the tasks ...

while the attribute docstring states:

We use a `Standardize` transform ...

and

Standardization should be applied in a stratified fashion ...

(note: should not is).

And the code is in line with the latter.

Please provide a minimal, reproducible example of the unexpected behavior.

(not needed)

Please paste any relevant traceback/logs produced by the example provided.


BoTorch Version

0.16.1

Python Version

No response

Operating System

No response

(Optional) Describe any potential fixes you've considered to the issue outlined above.

No response

Pull Request

None

Code of Conduct

  • [x] I agree to follow BoTorch's Code of Conduct

AdrianSosic avatar Nov 27 '25 14:11 AdrianSosic

@hvarfner you have the best understanding of this - can you help out?

Balandat avatar Nov 27 '25 16:11 Balandat

@AdrianSosic Thanks for pointing this out. As I'm sure you've checked already, the is in the main part of docstring is not correct. We've experimented with what one should do in this case, and it seems like stratified standardization is generally the safer choice. We may make it the default, but for now, I'll update the docstring.

hvarfner avatar Nov 28 '25 10:11 hvarfner

Fixed in https://github.com/meta-pytorch/botorch/pull/3093

saitcakmak avatar Dec 16 '25 19:12 saitcakmak