botorch icon indicating copy to clipboard operation
botorch copied to clipboard

Allow batched fixed features in `gen_candidates_scipy` and `gen_candidates_torch`

Open SamuelGabriel opened this issue 5 months ago • 4 comments

Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations.

We do this by allowing passing tensors of shape [b] or [b,q] to gen_candidates_scipy and for gen_candidates_torch for compatibility.

Differential Revision: D77043260

SamuelGabriel avatar Jun 25 '25 00:06 SamuelGabriel

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jun 25 '25 00:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jun 25 '25 00:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jun 25 '25 14:06 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d3d3c6f) to head (f029193). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2893   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        19778     19794   +16     
=========================================
+ Hits         19778     19794   +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 25 '25 14:06 codecov[bot]

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jul 02 '25 16:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jul 02 '25 16:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jul 02 '25 18:07 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D77043260

facebook-github-bot avatar Jul 02 '25 19:07 facebook-github-bot

This pull request has been merged in pytorch/botorch@78de86df762deb87cf6594177b41bb855e466174.

facebook-github-bot avatar Jul 02 '25 21:07 facebook-github-bot