botorch
botorch copied to clipboard
Avoid writing a "|" file in `run_tutorials` when runnnig a tutorial
I don't think this is necessary, and it creates a "|" file upon running tutorials that's annoying to deal with in git.
@esantorella I ran into this when fixing some timeouts, is there any reason for this pipe to be here?
Also, tangentially related, do we still need to write the results to a csv file upon executing tutorials if we don't upload those anymore?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.87%. Comparing base (
ed4bc4c) to head (8e05eae).
Additional details and impacted files
@@ Coverage Diff @@
## main #2237 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 188 188
Lines 16744 16744
=======================================
Hits 16723 16723
Misses 21 21
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
hmm nvm looks like this is needed after all in CI (this ran fine locally when running the module)?
@Balandat if this doesn't work, let's abandon the PR to remove it from the queue.