botorch icon indicating copy to clipboard operation
botorch copied to clipboard

Don't allow unused keyword arguments in Model.construct_inputs

Open esantorella opened this issue 1 year ago • 8 comments

Summary: BoTorch changes to go with the subsequent Ax diff. This will eventually need to be landed with this diff going before the Ax diff.

Differential Revision: D53086323

esantorella avatar Feb 01 '24 16:02 esantorella

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 01 '24 16:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 15 '24 21:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 22 '24 15:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 22 '24 15:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 28 '24 19:02 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.87%. Comparing base (dc219ca) to head (aab42e9). Report is 6 commits behind head on main.

:exclamation: Current head aab42e9 differs from pull request most recent head 7f0ab2c. Consider uploading reports for the commit 7f0ab2c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
- Coverage   99.97%   99.87%   -0.10%     
==========================================
  Files         197      188       -9     
  Lines       17165    16741     -424     
==========================================
- Hits        17160    16720     -440     
- Misses          5       21      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 19:02 codecov[bot]

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Feb 28 '24 22:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Mar 15 '24 19:03 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Apr 12 '24 17:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Apr 12 '24 22:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Apr 17 '24 21:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Apr 17 '24 22:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D53086323

facebook-github-bot avatar Apr 17 '24 22:04 facebook-github-bot

This pull request has been merged in pytorch/botorch@ee8aef0b66d83a1d2ab477f9a6e697a2175abc62.

facebook-github-bot avatar Apr 18 '24 14:04 facebook-github-bot