botorch icon indicating copy to clipboard operation
botorch copied to clipboard

acquisition function wrapper

Open sdaulton opened this issue 3 years ago • 7 comments

Summary: Add a wrapper for modifying inputs/outputs. This is useful for not only probabilistic reparameterization, but will also simplify other integrated AFs (e.g. MCMC) as well as fixed feature AFs and things like prior-guided AFs

Differential Revision: D41629186

sdaulton avatar Nov 30 '22 21:11 sdaulton

This pull request was exported from Phabricator. Differential Revision: D41629186

facebook-github-bot avatar Nov 30 '22 21:11 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D41629186

facebook-github-bot avatar Feb 04 '23 16:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D41629186

facebook-github-bot avatar Feb 08 '23 18:02 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D41629186

facebook-github-bot avatar Feb 08 '23 19:02 facebook-github-bot

Codecov Report

Merging #1532 (361650a) into main (63dd0cd) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 361650a differs from pull request most recent head 98fc27f. Consider uploading reports for the commit 98fc27f to get more accurate results

@@            Coverage Diff            @@
##              main     #1532   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          169       170    +1     
  Lines        14518     14525    +7     
=========================================
+ Hits         14518     14525    +7     
Impacted Files Coverage Δ
botorch/acquisition/fixed_feature.py 100.00% <100.00%> (ø)
botorch/acquisition/penalized.py 100.00% <100.00%> (ø)
botorch/acquisition/proximal.py 100.00% <100.00%> (ø)
botorch/acquisition/wrapper.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Feb 08 '23 19:02 codecov[bot]

This pull request was exported from Phabricator. Differential Revision: D41629186

facebook-github-bot avatar Feb 15 '23 00:02 facebook-github-bot

Hi @sdaulton!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 31 '23 07:03 facebook-github-bot