botorch
botorch copied to clipboard
add mixed optimization for list optimization
Motivation
As outlined in issue https://github.com/pytorch/botorch/issues/1272, optimize_acqf_list
cannot be used to optimize over mixed domains. For this reason, this PR introduces the argument fixed_features_list
for òptimize_acqf_list
. Calling optimize_acqf_list
with a list of fixed features invokes optimize_acqf_mixed
instead of optimize_acqf
under the hood.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
In principle unit tests, but I had problems to understand how the tests of the different optimisation functions work, perhaps @Balandat or @saitcakmak can help me here ;)
Related PRs
Codecov Report
Merging #1342 (b5c1620) into main (8ecc903) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #1342 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 149 149
Lines 12962 12966 +4
=========================================
+ Hits 12962 12966 +4
Impacted Files | Coverage Δ | |
---|---|---|
botorch/optim/optimize.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@saitcakmak: I implemented the test according to how I understood your suggestion. Can you have a look?
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.