botorch icon indicating copy to clipboard operation
botorch copied to clipboard

[Feature Request] optimize_acqf_list_mixed

Open jduerholt opened this issue 3 years ago • 1 comments

🚀 Feature Request

So far botorch offers helper functions to optimize a list of acquisition functions and to optimize over a mixed domain. A combination is not yet straight-forward possible and a helper function for this would be helpful. A possible use case would be for example a qnparego optimization over a mixed domain.

Pitch

From my point of view, the easiest solution would be to extend the optimize_acqf_list method with another argument called fixed_features_list which is initialized per default to None. If a list is provided the method could use optimize_acqf_mixed instead of optimize_acqf.

What do you think? If this solution sounds reasonable for you, I am happy to provide a PR.

jduerholt avatar Jun 29 '22 08:06 jduerholt

Hi @jduerholt! That sounds like a reasonable solution to me. Happy to review if you want to put up a PR for this.

saitcakmak avatar Jun 30 '22 17:06 saitcakmak

This was implemented in #1342

saitcakmak avatar Jan 09 '23 20:01 saitcakmak