benchmark icon indicating copy to clipboard operation
benchmark copied to clipboard

make MoCO model not distributed across multiple GPUs

Open nickgg opened this issue 4 years ago • 4 comments

The moco model is defined as a distrubuted NN, but we fix it to a single GPU in the benchmarks. Removing all the cross GPU communication for simplicitys sake.

nickgg avatar Sep 02 '20 18:09 nickgg

oh, can you also fix default device? And check off the box here: https://github.com/pytorch/benchmark/projects/1

wconstab avatar Sep 02 '20 18:09 wconstab

and make sure to raise NotImplemeted for jit? It looks like jit is silently disabled for now.

wconstab avatar Sep 02 '20 18:09 wconstab

I could comment out the code rather than delete it, but if/when we want to do distributed benchmarks probably easier to grab the copy from the original repo anyway.

The calls to nn.dist (eg the gathers) won't work if its not a DDP.

What do you mean by fix the default device and check off the project?

nickgg avatar Sep 02 '20 18:09 nickgg

ok, deleting or commenting is fine just wanted to ask.

oops, i sent the wrong link. check the moco specific 'nit' in this issue https://github.com/pytorch/benchmark/issues/65

wconstab avatar Sep 02 '20 19:09 wconstab

Addressed, closing this PR.

xuzhao9 avatar Aug 01 '23 14:08 xuzhao9