benchmark icon indicating copy to clipboard operation
benchmark copied to clipboard

[WIP] Raise RuntimeError when models are missing get_module() implementation

Open aaronenyeshi opened this issue 3 years ago • 2 comments

Since, we call get_module in each of the unit tests: train, eval, example, and check_device, the unit tests are skipped when get_module() is Not Implemented. This is because we catch NotImplemented in test.py. We should throw error when it is missing in any test.

aaronenyeshi avatar Nov 23 '21 00:11 aaronenyeshi

This change requires Issue #567 to be fixed.

aaronenyeshi avatar Nov 23 '21 00:11 aaronenyeshi

@xuzhao9 - I'm wondering if we should skip tests that don't have this implemented, so we can enforce this?

aaronenyeshi avatar Nov 30 '21 23:11 aaronenyeshi

Closing old prs

aaronenyeshi avatar Feb 15 '24 16:02 aaronenyeshi